Skip to content

ext/readline: update return typehints from bool to true #16545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

DanielEScherzer
Copy link
Member

These always return true

Copy link
Member

@Ayesh Ayesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Could use an entry in the UPGRADING file.

@DanielEScherzer
Copy link
Member Author

LGTM. Could use an entry in the UPGRADING file.

Given that this is basically internal documentation, I'm not entirely sure what to write - the functions that only returned true now enforce that?

@Ayesh
Copy link
Member

Ayesh commented Oct 23, 2024

Something like this will do, like we did for some functions in PHP 8.4:

readline_add_history, readline_clear_history, and readline_callback_handler_install functions
now have a return type of true instead of bool

@DanielEScherzer
Copy link
Member Author

Something like this will do, like we did for some functions in PHP 8.4:

readline_add_history, readline_clear_history, and readline_callback_handler_install functions
now have a return type of true instead of bool

Done

@Girgias Girgias merged commit 922bd2f into php:master Oct 25, 2024
9 of 10 checks passed
@DanielEScherzer DanielEScherzer deleted the readline-true branch October 25, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants